Conversation
Add the ,string JSON tag to Button.SkuId so uint64 SKU IDs are encoded/decoded as JSON strings. This avoids precision loss in JavaScript consumers and matches APIs that represent large numeric IDs as strings.
BenHall-1
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RM-257
Add the ,string JSON tag to Button.SkuId so uint64 SKU IDs are encoded/decoded as JSON strings. This avoids precision loss in JavaScript consumers and matches APIs that represent large numeric IDs as strings.
Both the API and worker needs to get gdl bumped when this is accepted
Type of Change
Testing
Checklist