Skip to content

RM-257: Fix being able to close a ticket, including a premium button#13

Merged
BenHall-1 merged 1 commit into
masterfrom
RM-257
Apr 26, 2026
Merged

RM-257: Fix being able to close a ticket, including a premium button#13
BenHall-1 merged 1 commit into
masterfrom
RM-257

Conversation

@biast12

@biast12 biast12 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Description

RM-257
Add the ,string JSON tag to Button.SkuId so uint64 SKU IDs are encoded/decoded as JSON strings. This avoids precision loss in JavaScript consumers and matches APIs that represent large numeric IDs as strings.

Both the API and worker needs to get gdl bumped when this is accepted

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Add the ,string JSON tag to Button.SkuId so uint64 SKU IDs are encoded/decoded as JSON strings. This avoids precision loss in JavaScript consumers and matches APIs that represent large numeric IDs as strings.
@biast12 biast12 requested a review from a team as a code owner April 20, 2026 13:58
@biast12 biast12 changed the title Fix being able to close a ticket, including a premium button RM-257: Fix being able to close a ticket, including a premium button Apr 20, 2026
@github-actions github-actions Bot added the type:bug Bug Fixes label Apr 25, 2026
@BenHall-1 BenHall-1 merged commit 999472e into master Apr 26, 2026
1 check passed
@BenHall-1 BenHall-1 deleted the RM-257 branch April 26, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants